[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce BITS_PER_TYPE (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 26 11:02:02 UTC 2018


== Series Details ==

Series: drm/i915: Introduce BITS_PER_TYPE (rev2)
URL   : https://patchwork.freedesktop.org/series/46055/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
589510c0b758 drm/i915: Introduce BITS_PER_TYPE
-:30: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#30: FILE: drivers/gpu/drm/i915/i915_drv.c:1653:
+	BUG_ON(device_info->gen > BITS_PER_TYPE(device_info->gen_mask));

-:69: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#69: FILE: drivers/gpu/drm/i915/i915_syncmap.c:95:
+	BUILD_BUG_ON(KSYNCMAP > BITS_PER_TYPE((*root)->bitmap));

-:96: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#96: FILE: drivers/gpu/drm/i915/intel_device_info.c:753:
+	BUILD_BUG_ON(I915_NUM_ENGINES > BITS_PER_TYPE(intel_ring_mask_t));

total: 0 errors, 3 warnings, 0 checks, 59 lines checked



More information about the Intel-gfx mailing list