[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/aml: Add new Amber Lake PCI ID (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 27 01:58:12 UTC 2018


== Series Details ==

Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL   : https://patchwork.freedesktop.org/series/50037/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b83389a0d094 drm/i915/aml: Add new Amber Lake PCI ID
-:52: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#52: FILE: include/drm/i915_pciids.h:368:
+#define INTEL_AML_KBL_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x591C, info),  /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */

-:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#52: FILE: include/drm/i915_pciids.h:368:
+#define INTEL_AML_KBL_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x591C, info),  /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */

total: 1 errors, 0 warnings, 1 checks, 46 lines checked



More information about the Intel-gfx mailing list