[Intel-gfx] [CI 1/6] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()
Dhinakaran Pandiyan
dhinakaran.pandiyan at intel.com
Fri Sep 28 20:30:46 UTC 2018
On Thursday, September 27, 2018 1:57:30 PM PDT Dhinakaran Pandiyan wrote:
> Comment claims link needs to be retrained because the connected sink raised
> a long pulse to indicate link loss. If the sink did so,
> intel_dp_hotplug() would have handled link retraining. Looking at the
> logs in Bugzilla referenced in commit '3cf71bc9904d ("drm/i915: Re-apply
> Perform link quality check, unconditionally during long pulse"")', the
> issue is that the sink does not trigger an interrupt. What we want is
> ->detect() from user space to check link status and retrain. Ville's
> review for the original patch also indicates the same root cause. So,
> rewrite the comment.
>
> v2: Patch split and rewrote comment.
I have pushed this series, thanks for the reviews.
-DK
More information about the Intel-gfx
mailing list