[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add Multi Segment Gamma Support (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Apr 2 12:44:05 UTC 2019


== Series Details ==

Series: Add Multi Segment Gamma Support (rev2)
URL   : https://patchwork.freedesktop.org/series/58169/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
75ad704a2b21 drm: Add gamma mode caps property
659fe8427470 drm/i915: Define color lut range structure
-:61: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#61: FILE: drivers/gpu/drm/i915/intel_color.c:1124:
+#define I965_GAMMA_10 \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 128, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = 0, .end = (1 << 10) - (1 << 10) / 128, \
+		.min = 0, .max = (1 << 16) - 1, \
+	}, \
+	/* PIPEGCMAX */ \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_REUSE_LAST | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 1, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = (1 << 10) - (1 << 10) / 128, .end = 1 << 10, \
+		.min = 0, .max = 1 << 16, \
+	}

total: 1 errors, 0 warnings, 0 checks, 320 lines checked
a059b6bf4fe1 drm: Add gamma mode property
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/drm_atomic_uapi.c:464:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->gamma_mode,

total: 0 errors, 0 warnings, 1 checks, 110 lines checked
a5deda67bb81 drm/i915/icl: Add register definitions for Multi Segmented gamma
3b03f07ba428 drm/i915/icl: Add support for multi segmented gamma mode
-:79: ERROR:TRAILING_WHITESPACE: trailing whitespace
#79: FILE: drivers/gpu/drm/i915/intel_color.c:719:
+^I$

-:102: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#102: FILE: drivers/gpu/drm/i915/intel_color.c:742:
+	 * from 3.0 to 7.0
+	*/

total: 1 errors, 1 warnings, 0 checks, 211 lines checked
7e97b366c05e drm/i915: Add gamma mode caps property
a7d35ed03858 drm/i915: Attach gamma mode property



More information about the Intel-gfx mailing list