[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part one

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 4 21:48:26 UTC 2019


== Series Details ==

Series: drm/i915: the great header refactoring, part one
URL   : https://patchwork.freedesktop.org/series/59022/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e3273176ce64 drm/i915: make intel_frontbuffer.h self-contained
9173569bc454 drm/i915: extract intel_audio.h from intel_drv.h
-:94: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#94: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 178 lines checked
17593127dc04 drm/i915: extract intel_crt.h from intel_drv.h
-:55: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 86 lines checked
f7505cd98351 drm/i915: extract intel_ddi.h from intel_drv.h
-:61: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 156 lines checked
29b3cb9772fe drm/i915: extract intel_connector.h from intel_drv.h
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 214 lines checked
d3dbcf35782d drm/i915: extract intel_csr.h from intel_drv.h
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

-:60: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#60: FILE: drivers/gpu/drm/i915/intel_csr.h:11:
+void intel_csr_ucode_init(struct drm_i915_private *);

-:61: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#61: FILE: drivers/gpu/drm/i915/intel_csr.h:12:
+void intel_csr_load_program(struct drm_i915_private *);

-:62: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#62: FILE: drivers/gpu/drm/i915/intel_csr.h:13:
+void intel_csr_ucode_fini(struct drm_i915_private *);

-:63: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#63: FILE: drivers/gpu/drm/i915/intel_csr.h:14:
+void intel_csr_ucode_suspend(struct drm_i915_private *);

-:64: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#64: FILE: drivers/gpu/drm/i915/intel_csr.h:15:
+void intel_csr_ucode_resume(struct drm_i915_private *);

total: 0 errors, 6 warnings, 0 checks, 51 lines checked
3b0c7907b1c7 drm/i915: extract intel_fbc.h from intel_drv.h
-:76: CHECK:LINE_SPACING: Please don't use multiple blank lines
#76: FILE: drivers/gpu/drm/i915/i915_suspend.c:27:
 
+

-:134: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#134: 
new file mode 100644

total: 0 errors, 1 warnings, 1 checks, 150 lines checked
1d43269827e3 drm/i915: extract intel_psr.h from intel_drv.h
-:202: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#202: 
new file mode 100644

-:221: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#221: FILE: drivers/gpu/drm/i915/intel_psr.h:15:
+#define CAN_PSR(dev_priv) (HAS_PSR(dev_priv) && dev_priv->psr.sink_support)

-:226: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#226: FILE: drivers/gpu/drm/i915/intel_psr.h:20:
+void intel_psr_disable(struct intel_dp *intel_dp,
+		      const struct intel_crtc_state *old_crtc_state);

-:231: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#231: FILE: drivers/gpu/drm/i915/intel_psr.h:25:
+			  unsigned frontbuffer_bits,

-:234: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#234: FILE: drivers/gpu/drm/i915/intel_psr.h:28:
+		     unsigned frontbuffer_bits,

total: 0 errors, 3 warnings, 2 checks, 195 lines checked
1e02d4859ef6 drm/i915: extract intel_color.h from intel_drv.h
-:33: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 43 lines checked
4aef051c5084 drm/i915: extract intel_lspcon.h from intel_drv.h
-:101: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#101: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 93 lines checked
a9b1119a8b8a drm/i915: extract intel_sdvo.h from intel_drv.h
-:75: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 57 lines checked
444cceac5b34 drm/i915: extract intel_hdcp.h from intel_drv.h
-:141: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#141: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 120 lines checked
7764ec95da8a drm/i915: extract intel_panel.h from intel_drv.h
-:189: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#189: 
new file mode 100644

-:253: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#253: FILE: drivers/gpu/drm/i915/intel_panel.h:60:
+}
+static inline void intel_backlight_device_unregister(struct intel_connector *connector)

total: 0 errors, 1 warnings, 1 checks, 197 lines checked
9169ad03c189 drm/i915: extract intel_pm.h from intel_drv.h
-:193: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#193: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 222 lines checked
9b50c8a6f31f drm/i915: extract intel_fbdev.h from intel_drv.h
-:160: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#160: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 162 lines checked
c9dd8b09cf61 drm/i915: extract intel_dp.h from intel_drv.h
-:93: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 342 lines checked
de1853ccd427 drm/i915: extract intel_hdmi.h from intel_drv.h
-:148: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#148: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
4fcb1b6c3c6d drm/i915: extract intel_atomic_plane.h from intel_drv.h
-:85: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 137 lines checked
c2bed9041cd5 drm/i915: extract intel_pipe_crc.h from intel_drv.h
-:75: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 74 lines checked
8552e096cde2 drm/i915: extract intel_tv.h from intel_drv.h
-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 36 lines checked
1baaf662b096 drm/i915: extract intel_lvds.h from intel_drv.h
-:75: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 56 lines checked
afe139e73b37 drm/i915: extract intel_dvo.h from intel_drv.h
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 35 lines checked
502027133de0 drm/i915: extract intel_sprite.h from intel_drv.h
-:163: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#163: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 152 lines checked
eef88940ccfa drm/i915: extract intel_cdclk.h from intel_drv.h
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 128 lines checked
65c3d8e5d782 drm/i915/cdclk: have only one init/uninit function



More information about the Intel-gfx mailing list