[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP2.2 Phase II (rev5)

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 5 11:16:51 UTC 2019


== Series Details ==

Series: HDCP2.2 Phase II (rev5)
URL   : https://patchwork.freedesktop.org/series/57232/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
932360ca743e drm: move content protection property to mode_config
1e7b8941c421 drm/i915: debugfs: HDCP2.2 capability read
6d5f2d176b2e drm: Add Content protection type property
-:63: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#63: FILE: drivers/gpu/drm/drm_connector.c:864:
+};
+DRM_ENUM_NAME_FN(drm_get_hdcp_content_type_name,

-:134: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#134: FILE: drivers/gpu/drm/drm_connector.c:1592:
+		prop = drm_property_create_enum(dev, 0, "HDCP Content Type",
+					drm_hdcp_content_type_enum_list,

-:135: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#135: FILE: drivers/gpu/drm/drm_connector.c:1593:
+					ARRAY_SIZE(

total: 0 errors, 0 warnings, 3 checks, 163 lines checked
624b5157e8a7 drm/i915: Attach content type property
7b179fdbc338 drivers: create binary sysfs for class
-:47: WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#47: FILE: drivers/base/class.c:597:
+EXPORT_SYMBOL_GPL(class_create_bin_file);

-:60: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#60: FILE: include/linux/device.h:486:
+extern int __must_check class_create_bin_file(struct class *class,

-:62: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#62: FILE: include/linux/device.h:488:
+extern void class_remove_bin_file(struct class *class,

total: 0 errors, 1 warnings, 2 checks, 41 lines checked
f3829f4402a1 drm: HDCP SRM binary sysfs for subsystem
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

-:346: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
#346: FILE: drivers/gpu/drm/drm_hdcp.c:310:
+	.attr = {.name = "hdcp_srm", .mode = S_IWUSR},

total: 0 errors, 2 warnings, 0 checks, 419 lines checked
a58112309f8b drm/i915: SRM revocation check for HDCP1.4 and 2.2
4a5a59c2d7bb drm/hdcp: gathering hdcp related code into drm_hdcp.c
-:140: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#140: FILE: drivers/gpu/drm/drm_hdcp.c:362:
+};
+DRM_ENUM_NAME_FN(drm_get_content_protection_name, drm_cp_enum_list)

-:146: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#146: FILE: drivers/gpu/drm/drm_hdcp.c:368:
+};
+DRM_ENUM_NAME_FN(drm_get_hdcp_content_type_name,

-:175: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#175: FILE: drivers/gpu/drm/drm_hdcp.c:397:
+int drm_connector_attach_content_protection_property(

-:199: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#199: FILE: drivers/gpu/drm/drm_hdcp.c:421:
+		prop = drm_property_create_enum(dev, 0, "HDCP Content Type",
+					drm_hdcp_content_type_enum_list,

-:200: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#200: FILE: drivers/gpu/drm/drm_hdcp.c:422:
+					ARRAY_SIZE(

-:236: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#236: FILE: include/drm/drm_hdcp.h:304:
+int drm_connector_attach_content_protection_property(

total: 0 errors, 0 warnings, 6 checks, 205 lines checked
752b736e5c40 drm: uevent for connector status change
dee5ccc79e99 drm/hdcp: update content protection property with uevent
-:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#30: FILE: drivers/gpu/drm/drm_hdcp.c:444:
+	drm_sysfs_connector_status_event(connector,
+				 dev->mode_config.content_protection_property);

total: 0 errors, 0 warnings, 1 checks, 23 lines checked
aa7b21ddf909 drm/i915: update the hdcp state with uevent
a3da0ea7bc24 drm: Add CP downstream_info property
-:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#135: FILE: drivers/gpu/drm/drm_hdcp.c:496:
+drm_connector_update_hdcp_topology_property(struct drm_connector *connector,
+					const struct hdcp_topology_info *info)

-:144: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#144: FILE: drivers/gpu/drm/drm_hdcp.c:505:
+	ret = drm_property_replace_global_blob(dev,
+			&connector->hdcp_topology_blob_ptr,

-:183: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#183: FILE: include/drm/drm_hdcp.h:309:
+int drm_connector_attach_hdcp_topology_property(

-:185: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#185: FILE: include/drm/drm_hdcp.h:311:
+int drm_connector_update_hdcp_topology_property(

total: 0 errors, 0 warnings, 4 checks, 193 lines checked
6a462ed58c3b drm/i915: Populate downstream info for HDCP
-:124: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#124: FILE: drivers/gpu/drm/i915/intel_hdcp.c:759:
+	if (drm_connector_update_hdcp_topology_property(&connector->base,
+						connector->hdcp.topology_info))

-:146: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#146: FILE: drivers/gpu/drm/i915/intel_hdcp.c:795:
+			if (drm_connector_update_hdcp_topology_property(

-:186: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#186: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1624:
+		drm_connector_update_hdcp_topology_property(&connector->base,
+							  hdcp->topology_info);

total: 0 errors, 0 warnings, 3 checks, 216 lines checked



More information about the Intel-gfx mailing list