[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Add support for DPLL4 (v3)

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 5 19:23:39 UTC 2019


== Series Details ==

Series: drm/i915/ehl: Add support for DPLL4 (v3)
URL   : https://patchwork.freedesktop.org/series/59078/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
946fdfff865f drm/i915/ehl: Add support for DPLL4 (v3)
-:72: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#72: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:2906:
+	min = max = DPLL_ID_ICL_MGPLL1;

-:97: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#97: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:3169:
+	if (IS_ELKHARTLAKE(dev_priv) &&
+	   (I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5 ||

-:110: ERROR:SPACING: space required after that ',' (ctx:VxV)
#110: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:3309:
+	{ "DPLL 4", &mg_pll_funcs, DPLL_ID_ICL_MGPLL1,0 },
 	                                             ^

total: 1 errors, 0 warnings, 2 checks, 83 lines checked



More information about the Intel-gfx mailing list