[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/29] drm/i915: Mark up ips for RCU protection
Patchwork
patchwork at emeril.freedesktop.org
Mon Apr 8 09:59:52 UTC 2019
== Series Details ==
Series: series starting with [01/29] drm/i915: Mark up ips for RCU protection
URL : https://patchwork.freedesktop.org/series/59155/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
17875d38d33a drm/i915: Mark up ips for RCU protection
bb6133046abe drm/i915/guc: Replace WARN with a DRM_ERROR
c9580bf3733f drm/i915: Use static allocation for i915_globals_park()
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15:
<4> [39.086121] 00000000004b5f91 (wakeref#3){+.+.}, at: intel_engine_pm_put+0x1b/0x40 [i915]
total: 0 errors, 1 warnings, 0 checks, 103 lines checked
c38bedbb5aef drm/i915: Consolidate the timeline->barrier
7af25481d1f9 drm/i915: Store the default sseu setup on the engine
-:383: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#383:
new file mode 100644
-:388: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#388: FILE: drivers/gpu/drm/i915/intel_sseu.c:1:
+/*
-:389: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#389: FILE: drivers/gpu/drm/i915/intel_sseu.c:2:
+ * SPDX-License-Identifier: MIT
-:536: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#536: FILE: drivers/gpu/drm/i915/intel_sseu.h:1:
+/*
-:537: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#537: FILE: drivers/gpu/drm/i915/intel_sseu.h:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 5 warnings, 0 checks, 533 lines checked
5b9f9fa1d320 drm/i915: Move GraphicsTechnology files under gt/
-:128: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#128:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 704 lines checked
bc642d18eac6 drm/i915: Only reset the pinned kernel contexts on resume
99753b992fca drm/i915: Introduce struct intel_wakeref
-:61: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#61:
new file mode 100644
-:66: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#66: FILE: drivers/gpu/drm/i915/intel_wakeref.c:1:
+/*
-:67: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#67: FILE: drivers/gpu/drm/i915/intel_wakeref.c:2:
+ * SPDX-License-Identifier: MIT
-:123: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#123: FILE: drivers/gpu/drm/i915/intel_wakeref.h:1:
+/*
-:124: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#124: FILE: drivers/gpu/drm/i915/intel_wakeref.h:2:
+ * SPDX-License-Identifier: MIT
-:138: WARNING:NEW_TYPEDEFS: do not add new typedefs
#138: FILE: drivers/gpu/drm/i915/intel_wakeref.h:16:
+typedef depot_stack_handle_t intel_wakeref_t;
-:142: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#142: FILE: drivers/gpu/drm/i915/intel_wakeref.h:20:
+ struct mutex mutex;
total: 0 errors, 6 warnings, 1 checks, 159 lines checked
4370dbe405cc drm/i915: Pull the GEM powermangement coupling into its own file
-:499: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#499:
new file mode 100644
-:504: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#504: FILE: drivers/gpu/drm/i915/i915_gem_pm.c:1:
+/*
-:505: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#505: FILE: drivers/gpu/drm/i915/i915_gem_pm.c:2:
+ * SPDX-License-Identifier: MIT
-:875: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#875: FILE: drivers/gpu/drm/i915/i915_gem_pm.h:1:
+/*
-:876: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#876: FILE: drivers/gpu/drm/i915/i915_gem_pm.h:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 5 warnings, 0 checks, 904 lines checked
d5b6883c1668 drm/i915: Introduce context->enter() and context->exit()
ba648fd79d72 drm/i915: Pass intel_context to i915_request_create()
8460d7b08fed drm/i915: Invert the GEM wakeref hierarchy
-:316: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#316:
new file mode 100644
-:321: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#321: FILE: drivers/gpu/drm/i915/gt/intel_engine_pm.c:1:
+/*
-:322: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#322: FILE: drivers/gpu/drm/i915/gt/intel_engine_pm.c:2:
+ * SPDX-License-Identifier: MIT
-:489: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#489: FILE: drivers/gpu/drm/i915/gt/intel_engine_pm.h:1:
+/*
-:490: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#490: FILE: drivers/gpu/drm/i915/gt/intel_engine_pm.h:2:
+ * SPDX-License-Identifier: MIT
-:547: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#547: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.c:1:
+/*
-:548: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#548: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.c:2:
+ * SPDX-License-Identifier: MIT
-:691: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#691: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.h:1:
+/*
-:692: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#692: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.h:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 9 warnings, 0 checks, 2167 lines checked
603ca7f02cae drm/i915/gvt: Pin the per-engine GVT shadow contexts
54c85fab6c7c drm/i915: Explicitly pin the logical context for execbuf
f6ff7ee156ff drm/i915/guc: Replace preempt_client lookup with engine->preempt_context
b283b276df90 drm/i915: Export intel_context_instance()
b556c5b31e3a drm/i915/selftests: Use the real kernel context for sseu isolation tests
df005e48a361 drm/i915/selftests: Pass around intel_context for sseu
af37325f8ba2 drm/i915: Pass intel_context to intel_context_pin_lock()
c72ee1eb49eb drm/i915: Split engine setup/init into two phases
4f8c507eab86 drm/i915: Switch back to an array of logical per-engine HW contexts
-:549: WARNING:LINE_SPACING: Missing a blank line after declarations
#549: FILE: drivers/gpu/drm/i915/i915_gem_context.h:214:
+ struct i915_gem_engines *e = rcu_dereference(ctx->engines);
+ if (likely(idx < e->num_engines && e->engines[idx]))
total: 0 errors, 1 warnings, 0 checks, 885 lines checked
98c2daab49d5 drm/i915: Remove intel_context.active_link
dfffb979bb26 drm/i915: Move i915_request_alloc into selftests/
-:394: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#394:
new file mode 100644
-:399: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#399: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.c:1:
+/*
-:400: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#400: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.c:2:
+ * SPDX-License-Identifier: MIT
-:448: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#448: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.h:1:
+/*
-:449: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#449: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.h:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 5 warnings, 0 checks, 394 lines checked
83efb37a5231 drm/i915: Allow multiple user handles to the same VM
fca3de8b6aaa drm/i915: Restore control over ppgtt for context creation ABI
-:80: WARNING:LONG_LINE: line over 100 characters
#80: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control)
-:81: WARNING:LONG_LINE: line over 100 characters
#81: FILE: include/uapi/drm/i915_drm.h:409:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:81: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#81: FILE: include/uapi/drm/i915_drm.h:409:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:81: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#81: FILE: include/uapi/drm/i915_drm.h:409:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
total: 1 errors, 3 warnings, 0 checks, 64 lines checked
0f931477a6b2 drm/i915: Allow a context to define its set of engines
-:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#415: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+ likely(__check_struct_size(sizeof(*(p)), \
+ sizeof(*(p)->member) + __must_be_array((p)->member), \
+ n, sz))
-:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#415: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+ likely(__check_struct_size(sizeof(*(p)), \
+ sizeof(*(p)->member) + __must_be_array((p)->member), \
+ n, sz))
-:415: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues
#415: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+ likely(__check_struct_size(sizeof(*(p)), \
+ sizeof(*(p)->member) + __must_be_array((p)->member), \
+ n, sz))
total: 0 errors, 0 warnings, 3 checks, 414 lines checked
45a6d1e2aba0 drm/i915: Allow userspace to clone contexts on creation
-:212: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#212: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1860:
+#define MAP(x, y) [ilog2(I915_CONTEXT_CLONE_##x)] = y
total: 1 errors, 0 warnings, 0 checks, 235 lines checked
9e4467a5ff80 drm/i915: Re-expose SINGLE_TIMELINE flags for context creation
ec9245b02fa1 drm/i915: Load balancing across a virtual engine
More information about the Intel-gfx
mailing list