[Intel-gfx] [PATCH 7/7] drm/i915/sdvo: Actually print the reason why the SDVO command failed

Ville Syrjala ville.syrjala at linux.intel.com
Tue Apr 9 14:40:54 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

It's much easier to figure out why the SDVO encoder refuses to cooperate
if we can see what status we got back.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_sdvo.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index d5a95eca23ba..5d928f6d0028 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -516,7 +516,7 @@ static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo,
 	u8 status;
 	int i, pos = 0;
 #define BUF_LEN 256
-	char buffer[BUF_LEN];
+	char buffer[BUF_LEN] = {};
 
 
 	/*
@@ -581,7 +581,8 @@ static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo,
 	return true;
 
 log_fail:
-	DRM_DEBUG_KMS("%s: R: ... failed\n", SDVO_NAME(intel_sdvo));
+	DRM_DEBUG_KMS("%s: R: ... failed %s\n",
+		      SDVO_NAME(intel_sdvo), buffer);
 	return false;
 }
 
-- 
2.21.0



More information about the Intel-gfx mailing list