[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix setting 10 bit color mode
Patchwork
patchwork at emeril.freedesktop.org
Tue Apr 9 20:16:23 UTC 2019
== Series Details ==
Series: drm/i915: Fix setting 10 bit color mode
URL : https://patchwork.freedesktop.org/series/59246/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d76f6b458d07 drm/i915: Fix setting 10 bit color mode
-:22: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#22:
Co-authored-by: Clint Taylor <clinton.a.taylor at intel.com>
-:49: ERROR:SPACING: space required before the open parenthesis '('
#49: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2328:
+ if(pipe_config->pipe_bpp == 36) {
-:49: CHECK:BRACES: braces {} should be used on all arms of this statement
#49: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2328:
+ if(pipe_config->pipe_bpp == 36) {
[...]
+ } else if (pipe_config->pipe_bpp == 30) {
[...]
+ } else
[...]
-:55: CHECK:BRACES: Unbalanced braces around else statement
#55: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2334:
+ } else
-:62: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#62: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2341:
+ hdmi_port_clock_valid(intel_hdmi, clock_bpc,
true, force_dvi) == MODE_OK) {
-:79: WARNING:LONG_LINE: line over 100 characters
#79: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2342:
+ DRM_DEBUG_KMS("picking bpc to %d for HDMI output\n",pipe_config->pipe_bpp/3);
-:79: ERROR:SPACING: space required after that ',' (ctx:VxV)
#79: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2342:
+ DRM_DEBUG_KMS("picking bpc to %d for HDMI output\n",pipe_config->pipe_bpp/3);
^
-:79: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#79: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2342:
+ DRM_DEBUG_KMS("picking bpc to %d for HDMI output\n",pipe_config->pipe_bpp/3);
^
total: 2 errors, 2 warnings, 4 checks, 60 lines checked
More information about the Intel-gfx
mailing list