[Intel-gfx] [PATCH 2/4] drm/i915/uc: Reserve upper range of GGTT

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 9 21:43:12 UTC 2019


Quoting Chris Wilson (2019-04-09 22:41:40)
> Quoting Fernando Pacheco (2019-04-09 22:31:00)
> > @@ -3370,7 +3388,8 @@ int i915_ggtt_probe_hw(struct drm_i915_private *dev_priv)
> >          * restriction!
> >          */
> >         if (USES_GUC(dev_priv)) {
> > -               ggtt->vm.total = min_t(u64, ggtt->vm.total, GUC_GGTT_TOP);
> > +               ggtt->vm.total = min_t(u64, ggtt->vm.total,
> > +                                      GUC_GGTT_RESERVED_END);
> 
> Should not be required now as you should have completely reserved the range
> for the guc, by the guc.

You can even then remove the comment, as we won't even try and put non
guc data here; guc or no guc is decided at module load.
-Chris


More information about the Intel-gfx mailing list