[Intel-gfx] [PATCH 7/7] drm/i915/icl: Don't warn on spurious interrupts

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 10 11:07:20 UTC 2019


Quoting Mika Kuoppala (2019-04-10 11:59:23)
> There is a chance we can see spurious interrupts in live
> now. We have more engines enabled and that with more elaborate
> access patterns with pm and display, increases the chances
> hardware just makes a social call, without anything to work on.
> 
> Remove the error as we have tests to actually probe if
> we really miss interrupt, instead of getting spurious ones.
> 
> Note that now we do write to intr_dw even with a zero
> value. This is considered advantegous as the write
> is an ack that sw is done.

Writing 0 back to 0 handled interrupts seems fair.
 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I think both interrupt handling patches should go in first, as they are
bug fixes that may be required even before rps is fixed.
-Chris


More information about the Intel-gfx mailing list