[Intel-gfx] [PATCH 1/2] drm/i915: Teach intel_workarounds to use uncore mmio access

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 12 21:48:08 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-04-12 22:45:29)
> 
> 
> On 4/12/19 1:24 PM, Chris Wilson wrote:
> > @@ -924,27 +924,22 @@ wa_list_apply(struct drm_i915_private *dev_priv, const struct i915_wa_list *wal)
> >       if (!wal->count)
> >               return;
> >   
> > -     fw = wal_get_fw_for_rmw(dev_priv, wal);
> > +     fw = wal_get_fw_for_rmw(uncore, wal);
> >   
> > -     spin_lock_irqsave(&dev_priv->uncore.lock, flags);
> > -     intel_uncore_forcewake_get__locked(&dev_priv->uncore, fw);
> > +     spin_lock_irqsave(&uncore->lock, flags);
> > +     intel_uncore_forcewake_get__locked(uncore, fw);
> >   
> >       for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
> 
> nitpick: brackets not needed anymore here.

Just saving a bit of churn with the next patch.
-Chris


More information about the Intel-gfx mailing list