[Intel-gfx] [PATCH v2 07/22] drm/i915/guc: Update GuC sleep status values

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Sat Apr 13 00:06:35 UTC 2019



On 4/11/19 1:44 AM, Michal Wajdeczko wrote:
> New GuC firmwares use updated sleep status definitions.
> 

There is also no need to poll on resume anymore. We're not failing on it 
in CI because the wait timeout comes out as a debug message and the guc 
is obviously still fine and responsive since we waited for nothing.

I think I had sent you a patch for this already, let me see if I can 
find it again and send it in reply to this one (if I do find it, I'm 
going to re-compile test it only).

Daniele

> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: John Spotswood <john.a.spotswood at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_guc_fwif.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 64b56da9775c..25d57c819e3f 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -648,9 +648,9 @@ enum intel_guc_report_status {
>   };
>   
>   enum intel_guc_sleep_state_status {
> -	INTEL_GUC_SLEEP_STATE_SUCCESS = 0x0,
> -	INTEL_GUC_SLEEP_STATE_PREEMPT_TO_IDLE_FAILED = 0x1,
> -	INTEL_GUC_SLEEP_STATE_ENGINE_RESET_FAILED = 0x2
> +	INTEL_GUC_SLEEP_STATE_SUCCESS = 0x1,
> +	INTEL_GUC_SLEEP_STATE_PREEMPT_TO_IDLE_FAILED = 0x2,
> +	INTEL_GUC_SLEEP_STATE_ENGINE_RESET_FAILED = 0x3
>   #define INTEL_GUC_SLEEP_STATE_INVALID_MASK 0x80000000
>   };
>   
> 


More information about the Intel-gfx mailing list