[Intel-gfx] [PATCH 0/3] i915/gvt/dmabuf: some plane 'size' fixes

[Uri Lublin]

On 4/15/19 5:14 AM, Zhenyu Wang wrote:
> On 2019.04.14 17:44:10 +0300, Uri Lublin wrote:
>> We started looking at the kvmgt driver code when we noticed
>> the 'size' calculation in qemu-kvm is wrong.
>> The first fix we had is now already committed upstream
>> (7f1a93b1f1d1d2603a49a9e4226259db9272f305).
>>      
>> There is a mismatch between the comment for 'size' field
>> of struct intel_vgpu_fb_info and the code.
>> The comment says the plane size is kept in bytes, while
>> the code keeps it in pages.
>> These patches fix this problem as well as some related
>> inconsistencies.
> 
> We have another series that would put size as bytes actually.
> https://patchwork.freedesktop.org/series/59260/

Hi,

We did look at gvt-staging branch but not at patchwork.

It seems the field description is still wrong.
In both structures, it says:
    "/* size of plane in bytes, align on page */"
But it seems possible that the value is not aligned on page.

Thanks,
    Uri and Snir

> 
> The first one is a fix for 5.1, and second one would be queued for
> next kernel.
> 
> thanks
>