[Intel-gfx] [PATCH 2/4] drm/i915: Verify the engine workarounds stick on application

[Chris Wilson]

Quoting Chris Wilson (2019-04-15 11:45:47)
> Quoting Tvrtko Ursulin (2019-04-15 11:41:43)
> > 
> > On 13/04/2019 13:58, Chris Wilson wrote:
> > > Read the engine workarounds back using the GPU after loading the initial
> > > context state to verify that we are setting them correctly, and bail if
> > > it fails.
> > 
> > Aren't the context wa/ ones we expect to see saved in the context? As 
> > such, what difference do you expect to see between mmio and srm 
> > verification? Should even both be done?
> 
> I was following a hunch that maybe these were being saved in the
> powercontext and so we needed an active engine to be able to read --
> just ruling out that maybe forcewake wasn't enough.

And yes, we do end up doing both read method to verify the writes :)
-Chris