[Intel-gfx] [PATCH] drm/i915: Enable workaround for pixel shader dispatch hang

[Mika Kuoppala]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Ville Syrjälä (2019-04-15 15:25:11)
>> On Mon, Apr 15, 2019 at 05:21:22PM +0300, Mika Kuoppala wrote:
>> > diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
>> > index ccaf63679435..4f1a7500ca07 100644
>> > --- a/drivers/gpu/drm/i915/intel_workarounds.c
>> > +++ b/drivers/gpu/drm/i915/intel_workarounds.c
>> > @@ -294,6 +294,15 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine)
>> >                         FLOW_CONTROL_ENABLE |
>> >                         PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
>> >  
>> > +     /* Bspec wa: 0651, skl G0 onwards */
>> > +     if (!IS_SKL_REVID(i915, SKL_REVID_A0, SKL_REVID_F0)) {
>> 
>> Aren't all those pre-production?
>
> intel_detect_preproduction_hw() says yes.

v2 coming up. The inverse check got left there as I needed
to filter out bxt ones. which turned out to be preprod.
The bell should have rung at that point, but didn't.
-Mika