[Intel-gfx] [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

Alastair D'Silva alastair at d-silva.org
Fri Apr 12 23:22:05 UTC 2019

> -----Original Message-----
> From: Petr Mladek <pmladek at suse.com>
> Sent: Friday, 12 April 2019 11:48 PM
> To: Alastair D'Silva <alastair at au1.ibm.com>
> Cc: alastair at d-silva.org; Jani Nikula <jani.nikula at linux.intel.com>;
> Lahtinen <joonas.lahtinen at linux.intel.com>; Rodrigo Vivi
> <rodrigo.vivi at intel.com>; David Airlie <airlied at linux.ie>; Daniel Vetter
> <daniel at ffwll.ch>; Karsten Keil <isdn at linux-pingi.de>; Jassi Brar
> <jassisinghbrar at gmail.com>; Tom Lendacky <thomas.lendacky at amd.com>;
> David S. Miller <davem at davemloft.net>; Jose Abreu
> <Jose.Abreu at synopsys.com>; Kalle Valo <kvalo at codeaurora.org>;
> Stanislaw Gruszka <sgruszka at redhat.com>; Benson Leung
> <bleung at chromium.org>; Enric Balletbo i Serra
> <enric.balletbo at collabora.com>; James E.J. Bottomley
> <jejb at linux.ibm.com>; Martin K. Petersen <martin.petersen at oracle.com>;
> Greg Kroah-Hartman <gregkh at linuxfoundation.org>; Alexander Viro
> <viro at zeniv.linux.org.uk>; Sergey Senozhatsky
> <sergey.senozhatsky at gmail.com>; Steven Rostedt <rostedt at goodmis.org>;
> Andrew Morton <akpm at linux-foundation.org>; intel-
> gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; linux-
> kernel at vger.kernel.org; netdev at vger.kernel.org;
> ath10k at lists.infradead.org; linux-wireless at vger.kernel.org; linux-
> scsi at vger.kernel.org; linux-fbdev at vger.kernel.org;
> devel at driverdev.osuosl.org; linux-fsdevel at vger.kernel.org
> Subject: Re: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line
> On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair at d-silva.org>
> >
> > With modern high resolution screens, we can display more data, which
> > makes life a bit easier when debugging.
> I have quite some doubts about this feature.
> We are talking about more than 256 characters per-line. I wonder if such a
> long line is really easier to read for a human.

It's basically 2 separate panes of information side by side, the hexdump and
the ASCII version.

I'm using this myself when dealing with the pmem labels, and it works quite

> I am not expert but there is a reason why the standard is 80 characters
> line. I guess that anything above 100 characters is questionable.
> https://en.wikipedia.org/wiki/Line_length
> somehow confirms that.
> Second, if we take 8 pixels per-character. Then we need
> 2048 to show the 256 characters. It is more than HD.
> IMHO, there is still huge number of people that even do not have HD
> especially on a notebook.

The intent is to make debugging easier when dealing with large chunks of
binary data. I don't expect end users to see this output.

Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva     msn: alastair at d-silva.org
blog: http://alastair.d-silva.org    Twitter: @EvilDeece

More information about the Intel-gfx mailing list