[Intel-gfx] [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line
alastair at d-silva.org
Mon Apr 15 10:29:08 UTC 2019
> > > On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote:
> > > > From: Alastair D'Silva <alastair at d-silva.org>
> > > >
> > > > With modern high resolution screens, we can display more data,
> > > > which makes life a bit easier when debugging.
> > >
> > > I have quite some doubts about this feature.
> > >
> > > We are talking about more than 256 characters per-line. I wonder if
> > > such a long line is really easier to read for a human.
> > It's basically 2 separate panes of information side by side, the
> > hexdump and the ASCII version.
> > I'm using this myself when dealing with the pmem labels, and it works
> > quite nicely.
> I am sure that it works for you. But I do not believe that it would be
I do, and I believe the choice of the output length should be in the hands
of the caller.
On further thought, it would make more sense to remove the hardcoded list of
sizes and just enforce a power of 2. The function shouldn't dictate what the
caller can and can't do beyond the technical limits of it's implementation.
Other print/debug functions don't restrict the output size, and I can't see
a good justification why hexdump should either.
> > > I am not expert but there is a reason why the standard is 80
> > > characters
> > per-
> > > line. I guess that anything above 100 characters is questionable.
> > > https://en.wikipedia.org/wiki/Line_length
> > > somehow confirms that.
> > >
> > > Second, if we take 8 pixels per-character. Then we need
> > > 2048 to show the 256 characters. It is more than HD.
> > > IMHO, there is still huge number of people that even do not have HD
> > display,
> > > especially on a notebook.
> > The intent is to make debugging easier when dealing with large chunks
> > of binary data. I don't expect end users to see this output.
> How is it supposed to be used then? Only by your temporary patches?
Let me rephrase that, I don't expect end users to *use* this data.
Current usage of the hexdump functions are predominantly centred around
logging and debugging, and clearly targeted at someone intimately familiar
with the relevant subsystem. I expect future use would be similar.
Debugging may be as part of active development, or from a log supplied from
an end user. In either case, it should be up to the author (as a
representative for the consumers of the data) to decide how it should be
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva msn: alastair at d-silva.org
blog: http://alastair.d-silva.org Twitter: @EvilDeece
More information about the Intel-gfx