[Intel-gfx] [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line
alastair at d-silva.org
Mon Apr 15 10:59:36 UTC 2019
> From: Alastair D'Silva
> > Sent: 15 April 2019 11:29
> > I do, and I believe the choice of the output length should be in the
> > hands of the caller.
> > On further thought, it would make more sense to remove the hardcoded
> > list of sizes and just enforce a power of 2. The function shouldn't
> > dictate what the caller can and can't do beyond the technical limits of it's
> Why powers of two?
> You may want the length to match sizeof (struct foo).
> You might even want the address increment to be larger that the number of
> lines dumped.
Good point, the base requirement is that it should be a multiple of groupsize.
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva msn: alastair at d-silva.org
blog: http://alastair.d-silva.org Twitter: @EvilDeece
More information about the Intel-gfx