[Intel-gfx] [PATCH 3/4] drm/i915: Split pch irq handling to ack+handler

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 15 16:48:04 UTC 2019


Quoting Ville Syrjala (2019-04-15 16:49:03)
> @@ -2563,15 +2613,20 @@ static void ilk_display_irq_handler(struct drm_i915_private *dev_priv,
>  
>         /* check event from PCH */
>         if (de_iir & DE_PCH_EVENT) {
> -               u32 pch_iir = I915_READ(SDEIIR);
> +               struct pch_irq_regs pch = {};

If I am following along correctly, we don't need the memset here as we
only ever check dependent members after a guard (such as the iir or
hotplug trigger).

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list