[Intel-gfx] [PATCH] drm/i915/selftests: Verify whitelist of context registers

[Dan Carpenter]

Hi Chris,

Thank you for the patch! Perhaps something to improve:

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests-Verify-whitelist-of-context-registers/20190416-105231
base:   git://anongit.freedesktop.org/drm-intel for-linux-next

New smatch warnings:
drivers/gpu/drm/i915/selftests/intel_workarounds.c:846 scrub_whitelisted_registers() error: uninitialized symbol 'err'.

# https://github.com/0day-ci/linux/commit/a9ce77a003ecaa54f530f1e9ff81cbae11380380
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout a9ce77a003ecaa54f530f1e9ff81cbae11380380
vim +/PTR_ERR +759 drivers/gpu/drm/i915/selftests/intel_workarounds.c

a9ce77a0 Chris Wilson 2019-04-15  794  static int scrub_whitelisted_registers(struct i915_gem_context *ctx,
a9ce77a0 Chris Wilson 2019-04-15  795  				       struct intel_engine_cs *engine)
a9ce77a0 Chris Wilson 2019-04-15  796  {
a9ce77a0 Chris Wilson 2019-04-15  797  	intel_wakeref_t wakeref;
a9ce77a0 Chris Wilson 2019-04-15  798  	struct i915_request *rq;
a9ce77a0 Chris Wilson 2019-04-15  799  	struct i915_vma *batch;
a9ce77a0 Chris Wilson 2019-04-15  800  	int i, err;
a9ce77a0 Chris Wilson 2019-04-15  801  	u32 *cs;
a9ce77a0 Chris Wilson 2019-04-15  802  
a9ce77a0 Chris Wilson 2019-04-15  803  	batch = create_batch(ctx);
a9ce77a0 Chris Wilson 2019-04-15  804  	if (IS_ERR(batch))
a9ce77a0 Chris Wilson 2019-04-15  805  		return PTR_ERR(batch);
a9ce77a0 Chris Wilson 2019-04-15  806  
a9ce77a0 Chris Wilson 2019-04-15  807  	cs = i915_gem_object_pin_map(batch->obj, I915_MAP_WC);
a9ce77a0 Chris Wilson 2019-04-15  808  	if (IS_ERR(cs)) {
a9ce77a0 Chris Wilson 2019-04-15  809  		err = PTR_ERR(cs);
a9ce77a0 Chris Wilson 2019-04-15  810  		goto err_batch;
a9ce77a0 Chris Wilson 2019-04-15  811  	}
a9ce77a0 Chris Wilson 2019-04-15  812  
a9ce77a0 Chris Wilson 2019-04-15  813  	*cs++ = MI_LOAD_REGISTER_IMM(engine->whitelist.count);
a9ce77a0 Chris Wilson 2019-04-15  814  	for (i = 0; i < engine->whitelist.count; i++) {
a9ce77a0 Chris Wilson 2019-04-15  815  		*cs++ = i915_mmio_reg_offset(engine->whitelist.list[i].reg);
a9ce77a0 Chris Wilson 2019-04-15  816  		*cs++ = STACK_MAGIC;
a9ce77a0 Chris Wilson 2019-04-15  817  	}
a9ce77a0 Chris Wilson 2019-04-15  818  	*cs++ = MI_BATCH_BUFFER_END;
a9ce77a0 Chris Wilson 2019-04-15  819  
a9ce77a0 Chris Wilson 2019-04-15  820  	i915_gem_object_flush_map(batch->obj);
a9ce77a0 Chris Wilson 2019-04-15  821  	i915_gem_chipset_flush(ctx->i915);
a9ce77a0 Chris Wilson 2019-04-15  822  
a9ce77a0 Chris Wilson 2019-04-15  823  	rq = ERR_PTR(-ENODEV);
a9ce77a0 Chris Wilson 2019-04-15  824  	with_intel_runtime_pm(engine->i915, wakeref)
a9ce77a0 Chris Wilson 2019-04-15  825  		rq = i915_request_alloc(engine, ctx);
a9ce77a0 Chris Wilson 2019-04-15  826  	if (IS_ERR(rq))
a9ce77a0 Chris Wilson 2019-04-15  827  		goto err_unpin;
                                                ^^^^^^^^^^^^^^
"err" not set.

a9ce77a0 Chris Wilson 2019-04-15  828  
a9ce77a0 Chris Wilson 2019-04-15  829  	if (engine->emit_init_breadcrumb) { /* Be nice if we hang */
a9ce77a0 Chris Wilson 2019-04-15  830  		err = engine->emit_init_breadcrumb(rq);
a9ce77a0 Chris Wilson 2019-04-15  831  		if (err)
a9ce77a0 Chris Wilson 2019-04-15  832  			goto err_request;
a9ce77a0 Chris Wilson 2019-04-15  833  	}
a9ce77a0 Chris Wilson 2019-04-15  834  
a9ce77a0 Chris Wilson 2019-04-15  835  	err = engine->emit_bb_start(rq, batch->node.start, 0, 0);
a9ce77a0 Chris Wilson 2019-04-15  836  
a9ce77a0 Chris Wilson 2019-04-15  837  err_request:
a9ce77a0 Chris Wilson 2019-04-15  838  	i915_request_add(rq);
a9ce77a0 Chris Wilson 2019-04-15  839  	if (i915_request_wait(rq, I915_WAIT_LOCKED, HZ / 5) < 0)
a9ce77a0 Chris Wilson 2019-04-15  840  		err = -EIO;
a9ce77a0 Chris Wilson 2019-04-15  841  
a9ce77a0 Chris Wilson 2019-04-15  842  err_unpin:
a9ce77a0 Chris Wilson 2019-04-15  843  	i915_gem_object_unpin_map(batch->obj);
a9ce77a0 Chris Wilson 2019-04-15  844  err_batch:
a9ce77a0 Chris Wilson 2019-04-15  845  	i915_vma_unpin_and_release(&batch, 0);
a9ce77a0 Chris Wilson 2019-04-15 @846  	return err;
a9ce77a0 Chris Wilson 2019-04-15  847  }
a9ce77a0 Chris Wilson 2019-04-15  848  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation