[Intel-gfx] [patch V2 14/29] dm bufio: Simplify stack trace retrieval

Thomas Gleixner tglx at linutronix.de
Thu Apr 18 11:54:37 UTC 2019

On Thu, 18 Apr 2019, Alexander Potapenko wrote:
> On Thu, Apr 18, 2019 at 11:06 AM Thomas Gleixner <tglx at linutronix.de> wrote:
> > -       save_stack_trace(&b->stack_trace);
> > +       b->stack_len = stack_trace_save(b->stack_entries, MAX_STACK, 2);
> As noted in one of similar patches before, can we have an inline
> comment to indicate what does this "2" stand for?

Come on. We have gazillion of functions which take numerical constant
arguments. Should we add comments to all of them?



More information about the Intel-gfx mailing list