[Intel-gfx] [RFC 0/8] Start some re-org around IRQ.

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Apr 18 20:53:39 UTC 2019

When playing with IRQ code here I noticed many IRQ stuff
are spreaded all around our code. So I'm starting the
organization by consolidating as much as possible on a
new intel_irq.

So we could use this intel_irq to pass around as argument
instead of dev_priv, i915 or uncore.

So, besides starting that change we need to continue
working towards the conversion of intel_uncore_*().

Another possibilities to exploer after that is to fully
split rps and hotplug code out of irq.

Latest but not least it may be possible to split gt_irq
from de_irq later.

But well, for now please give feed back on intel_irq
struct idea.


Rodrigo Vivi (8):
  drm/i915: Introduce intel_irq
  drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq.
  drm/i915: Move display_irqs_enabled to intel_irq
  drm/i915: Consolidated iir, imr and ier.
  drm/i915: Move all irq related masks to intel_irq
  drm/i915: Prefer passing intel_irq instead of intel_core
  drm/i915: Start the conversion from passing intel_irq instead of
  drm/i915: Migrate more gen11 irq functions towards intel_irq and
    uncore funcs.

 drivers/gpu/drm/i915/i915_debugfs.c        |   8 +-
 drivers/gpu/drm/i915/i915_drv.c            |   6 +-
 drivers/gpu/drm/i915/i915_drv.h            |  39 +-
 drivers/gpu/drm/i915/i915_irq.c            | 642 +++++++++++----------
 drivers/gpu/drm/i915/intel_breadcrumbs.c   |   8 +-
 drivers/gpu/drm/i915/intel_display.c       |   4 +-
 drivers/gpu/drm/i915/intel_drv.h           |   2 +-
 drivers/gpu/drm/i915/intel_engine_types.h  |   2 +-
 drivers/gpu/drm/i915/intel_fifo_underrun.c |  30 +-
 drivers/gpu/drm/i915/intel_hotplug.c       |  48 +-
 drivers/gpu/drm/i915/intel_ringbuffer.c    |  16 +-
 drivers/gpu/drm/i915/intel_runtime_pm.c    |   8 +-
 drivers/gpu/drm/i915/intel_tv.c            |   8 +-
 13 files changed, 417 insertions(+), 404 deletions(-)


More information about the Intel-gfx mailing list