[Intel-gfx] [PATCH v2 4/7] drm/i915/sdvo: Check that we have space for the infoframe

Sripada, Radhakrishna radhakrishna.sripada at intel.com
Mon Apr 22 18:37:48 UTC 2019


On Wed, 2019-04-10 at 20:08 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Before we go writing the infoframe let's make sure we have
> the space for it. Not that it really matters since the write
> loop would just terminate early in that case.
> 
> v2: Check after the debug print and ++ (Chris)
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/intel_sdvo.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
> b/drivers/gpu/drm/i915/intel_sdvo.c
> index 7f64352a3413..14348dfb024a 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -976,6 +976,9 @@ static bool intel_sdvo_write_infoframe(struct
> intel_sdvo *intel_sdvo,
>  	DRM_DEBUG_KMS("writing sdvo hbuf: %i, hbuf_size %i, hbuf_size:
> %i\n",
>  		      if_index, length, hbuf_size);
If the above line is newly added why dont I See a + at the beginning of
the line? Is it from a previous version of the patch?

-Radhakrishna(RK) Sripada
>  
> +	if (hbuf_size < length)
> +		return false;
> +
>  	for (i = 0; i < hbuf_size; i += 8) {
>  		memset(tmp, 0, 8);
>  		if (i < length)


More information about the Intel-gfx mailing list