[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine relative MMIO (rev4)

Patchwork patchwork at emeril.freedesktop.org
Wed Apr 24 02:49:25 UTC 2019


== Series Details ==

Series: drm/i915: Engine relative MMIO (rev4)
URL   : https://patchwork.freedesktop.org/series/57117/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f8a1f0afe196 drm/i915: Engine relative MMIO
-:92: ERROR:SPACING: space prohibited after that open parenthesis '('
#92: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:223:
+	CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,

-:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#93: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:224:
+	CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,
 	      .reg = { .offset = 1, .mask = 0x007FFFFC, .step = 2 }    ),

-:250: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#250: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
                                  	                ^

-:250: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#250: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
                                  	                    ^

-:252: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#252: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:132:
+#define   MI_LRI_ADD_CS_MMIO_START_GEN11	(1<<19)
                                         	  ^

-:395: ERROR:CODE_INDENT: code indent should use tabs where possible
#395: FILE: drivers/gpu/drm/i915/intel_lrc.c:2789:
+ ^ICTX_REG(engine, regs, CTX_PDP3_UDW, GEN8_RING_PDP_UDW(base, 3), 0);$

-:395: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#395: FILE: drivers/gpu/drm/i915/intel_lrc.c:2789:
+ ^ICTX_REG(engine, regs, CTX_PDP3_UDW, GEN8_RING_PDP_UDW(base, 3), 0);$

-:395: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#395: FILE: drivers/gpu/drm/i915/intel_lrc.c:2789:
+ ^ICTX_REG(engine, regs, CTX_PDP3_UDW, GEN8_RING_PDP_UDW(base, 3), 0);$

-:539: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#539: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:1762:
+	*cs++ = i915_get_lri_cmd(rq->engine, GEN7_L3LOG_SIZE/4);
 	                                                    ^

-:607: CHECK:CAMELCASE: Avoid CamelCase: <regLRI>
#607: FILE: drivers/gpu/drm/i915/selftests/intel_workarounds.c:447:
+		u32 regLRI = i915_get_lri_reg(engine, engine->whitelist.list[i].reg);

total: 2 errors, 2 warnings, 6 checks, 503 lines checked



More information about the Intel-gfx mailing list