[Intel-gfx] [PATCH 14/45] drm/i915: Make engine_mask & num_engines static
tvrtko.ursulin at linux.intel.com
Thu Apr 25 10:43:03 UTC 2019
On 25/04/2019 11:30, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-25 11:20:47)
>> On 25/04/2019 10:19, Chris Wilson wrote:
>>> Having removed the urge to modify the engine_mask at runtime, we can
>>> promote the num_engines from a runtime calculation to a static and push
>>> it into the device_info tables.
>> What about fused off engines (intel_device_info_init_mmio)?
> Didn't notice. :((
> Plan B was just to calculate num_engines at point of use, since it is
> rare enough.
I'd just leave it in runtime info for now. Don't see a benefit of moving it.
If I can find my last series which tried to eliminate mkwrite and reduce
runtime info, there were some notes in the resulting threads about which
fields have what problems associated with them. I only remember the gen
field was looking like easy pickings..
> Oh well, this pair of patches was just inspired because I touched the
> cleanup code and not important.
.. please restrain the inspiration if ahead of media scalability
otherwise we will never be done with it! :))
More information about the Intel-gfx