[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add in-kernel blitter client

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 26 22:52:36 UTC 2019


== Series Details ==

Series: drm/i915: add in-kernel blitter client
URL   : https://patchwork.freedesktop.org/series/60017/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
658ea31e573a drm/i915: add in-kernel blitter client
-:43: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#43: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:183:
+#define XY_COLOR_BLT_CMD		(2<<29 | 0x50<<22)
                         		  ^

-:43: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#43: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:183:
+#define XY_COLOR_BLT_CMD		(2<<29 | 0x50<<22)
                         		             ^

-:75: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

-:228: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!work"
#228: FILE: drivers/gpu/drm/i915/i915_gem_client_blt.c:149:
+	if (work == NULL) {

-:328: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#328: FILE: drivers/gpu/drm/i915/i915_gem_object_blt.c:30:
+		*cs++ = XY_COLOR_BLT_CMD | BLT_WRITE_RGBA | (7-2);
 		                                              ^

-:337: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#337: FILE: drivers/gpu/drm/i915/i915_gem_object_blt.c:39:
+		*cs++ = XY_COLOR_BLT_CMD | BLT_WRITE_RGBA | (6-2);
 		                                              ^

-:441: WARNING:LINE_SPACING: Missing a blank line after declarations
#441: FILE: drivers/gpu/drm/i915/selftests/i915_gem_client_blt.c:17:
+	struct rnd_state prng;
+	IGT_TIMEOUT(end);

-:570: WARNING:LINE_SPACING: Missing a blank line after declarations
#570: FILE: drivers/gpu/drm/i915/selftests/i915_gem_object_blt.c:17:
+	struct rnd_state prng;
+	IGT_TIMEOUT(end);

total: 0 errors, 3 warnings, 5 checks, 601 lines checked



More information about the Intel-gfx mailing list