[Intel-gfx] [PATCH] drm/i915/pmu: Atomically acquire the gt_pm wakeref

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 1 15:23:42 UTC 2019


Quoting Tvrtko Ursulin (2019-08-01 15:55:29)
> 
> On 01/08/2019 15:39, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-08-01 15:21:17)
> >> I guess I'll be rebasing mine, at some point. :)
> > 
> > I anticipated you merging it at some point.
> 
> This patch to my series or what?

Your series to update the locals, those first patches should be
non-controversial. The fixup is trivial either way.
 
> > Had a thought, and we don't need gt_pm for the engine sampling, but
> > rather intel_engine_pm_get_if_awake.
> 
> I thought about it, but since we iterate all engines did not see a real 
> benefit. Wouldn't harm either, only some more CPU cycles in the loop, so 
> up to you.

But also likely to save some work on larger devices if they are mostly
idle, which I hope they typically are.
-Chris


More information about the Intel-gfx mailing list