[Intel-gfx] [PATCH] drm/i915: Cancel persistent contexts if !hangcheck

[Chris Wilson]

Quoting Andi Shyti (2019-08-06 09:35:49)
> Hi Chris,
> 
> > +static void kill_context(struct i915_gem_context *ctx)
> > +{
> > +     struct i915_gem_engines_iter it;
> > +     struct intel_engine_cs *engine;
> > +     intel_engine_mask_t tmp, active;
> > +     struct intel_context *ce;
> > +
> > +     if (i915_gem_context_is_banned(ctx))
> > +             return;
> 
> just a question, if a context is "banned", don't we want to check
> on the requests anyway?

If the context is already banned, it means the request will be banned on
submission and the previously active request was found guilty and thrown
away.

> > +++ b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
> 
> heartbeat? I like it :)
> 
> Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Ooops, should have flagged this as a very much RFC. It's still
incomplete (namely evicting active requests needs some backend support).
And I've yet to throw it against the wall to see if it sticks.
-Chris