[Intel-gfx] [PATCH 00/10] drm/i915: some more header juggling

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 6 10:36:56 UTC 2019


Quoting Jani Nikula (2019-08-06 11:07:21)
> The big theme here is to emphasize that intel_drv.h is a display header, so
> rename it display/intel_display_types.h and reduce its use in non-display
> code. Also reduce the inclusion of that and the other mega header i915_drv.h
> from other headers.
> 
> BR,
> Jani.
> 
> 
> Jani Nikula (10):
>   drm/i915: move intel_display.c function declarations
>   drm/i915/sprite: un-inline icl_is_hdr_plane()
>   drm/i915/irq: un-inline functions to avoid i915_drv.h include
>   drm/i915/bw: make intel_atomic_get_bw_state() static
>   drm/i915/mst: un-inline intel_dp_mst_encoder_active_links()
>   drm/i915/tc: un-inline intel_tc_port_ref_held()
>   drm/i915: avoid including intel_drv.h via i915_drv.h->i915_trace.h
>   drm/i915: rename intel_drv.h to display/intel_display_types.h
>   drm/i915: remove unnecessary includes of intel_display_types.h header
>   drm/i915: move property enums to intel_display_types.h

A few moments of exasperation of "we use that there!?", but looks all
dandy. I didn't spot anything other than mechanical translations and I
agree with the direction,

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list