[Intel-gfx] ✓ Fi.CI.BAT: success for Hardening firmware fetch (rev2)

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 7 20:19:19 UTC 2019


Quoting Patchwork (2019-08-07 20:42:47)
> == Series Details ==
> 
> Series: Hardening firmware fetch (rev2)
> URL   : https://patchwork.freedesktop.org/series/64856/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6649 -> Patchwork_13907
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.

None found, but still some worrying warnings for me. Oh well, pushed with
one minor edit for a compile warning,

 static void __force_fw_fetch_failures(struct intel_uc_fw *uc_fw,
-                                     struct drm_i915_private *i915, bool user)
+                                     struct drm_i915_private *i915,
+                                     int e)
 {
-       int e = user ? -EINVAL : -ESTALE;
+       bool user = e == -EINVAL;

        if (i915_inject_load_error(i915, e)) {
                /* non-existing blob */
@@ -267,8 +268,8 @@ int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw, struct drm_i915_private *i915)
        if (err)
                return err;

-       __force_fw_fetch_failures(uc_fw, i915, true);
-       __force_fw_fetch_failures(uc_fw, i915, false);
+       __force_fw_fetch_failures(uc_fw, i915, -EINVAL);
+       __force_fw_fetch_failures(uc_fw, i915, -ESTALE);
-Chris


More information about the Intel-gfx mailing list