[Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting

[Chris Wilson]

Quoting Mika Kuoppala (2019-08-08 16:26:35)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > To actually DROP_IDLE means that we have to wait for ongoing submission,
> > and any new concurrently submitted, i.e. it should only be called during
> > single-threaded submission to ensure the GPU is idle before the new
> > action.
> >
> > v2: Also include SHRINK for thrash-all-the-things, and find a dupe in
> > gem_reloc_vs_gpu.
> 
> Agreed that is rather pointless trying to guarantee an idle gpu
> during a test.
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> 
> But between a tests, it will serve as a flush?

At the end of a _test_ (binary), we do reset and idle the GPU. The
theory is that we want each test to have a clean slate, and to catch any
residual problems in the test that created them.

But we don't do anything between subtests by default, and we frequently
run into problems there if one subtest fails and causes the next to
fail and so on and so on. An unsolved dilemma.
-Chris