[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] dma-buf: add reservation_object_fences helper

Patchwork patchwork at emeril.freedesktop.org
Fri Aug 9 13:07:16 UTC 2019


== Series Details ==

Series: series starting with [1/4] dma-buf: add reservation_object_fences helper
URL   : https://patchwork.freedesktop.org/series/64955/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6ff342a1513c dma-buf: add reservation_object_fences helper
-:25: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#25: FILE: drivers/dma-buf/dma-buf.c:202:
+	unsigned shared_count;

-:191: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#191: FILE: drivers/dma-buf/reservation.c:508:
+	unsigned shared_count;

-:238: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#238: FILE: drivers/dma-buf/reservation.c:599:
+	unsigned shared_count;

-:427: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 4 warnings, 0 checks, 381 lines checked
aaef55f6b88d drm/i915: use new reservation_object_fences helper
-:61: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 1 warnings, 0 checks, 43 lines checked
5dd5e3f55895 dma-buf: further relax reservation_object_add_shared_fence
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
Other cores don't busy wait any more and we removed the last user of checking

-:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 2 warnings, 0 checks, 31 lines checked
ee9de2492811 dma-buf: nuke reservation_object seq number
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
The only remaining use for this is to protect against setting a new exclusive

-:57: WARNING:MEMORY_BARRIER: memory barrier without comment
#57: FILE: drivers/dma-buf/reservation.c:279:
+		smp_store_mb(old->shared_count, 0);

-:112: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 3 warnings, 0 checks, 80 lines checked



More information about the Intel-gfx mailing list