[Intel-gfx] [PATCH v3 28/37] drm/i915: check for missing aperture in insert_mappable_node

Chris Wilson chris at chris-wilson.co.uk
Sat Aug 10 11:15:08 UTC 2019


Quoting Matthew Auld (2019-08-09 23:26:34)
> From: CQ Tang <cq.tang at intel.com>
> 
> Signed-off-by: CQ Tang <cq.tang at intel.com>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 2aa4fbe7edc0..af63d1a0af14 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -64,6 +64,9 @@ static int
>  insert_mappable_node(struct i915_ggtt *ggtt,
>                       struct drm_mm_node *node, u32 size)
>  {
> +       if (!ggtt->mappable_end)
> +               return -ENOSPC;

How did you get here? This should remain the BUG for the programming
error.
-Chris


More information about the Intel-gfx mailing list