[Intel-gfx] [PATCH] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock
kbuild test robot
lkp at intel.com
Mon Aug 12 15:29:38 UTC 2019
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v5.3-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-execlists-Lift-process_csb-out-of-the-irq-off-spinlock/20190812-211057
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_in':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:541:2: error: implicit declaration of function 'intel_context_inflight_inc'; did you mean 'intel_context_inflight_count'? [-Werror=implicit-function-declaration]
intel_context_inflight_inc(rq->hw_context);
^~~~~~~~~~~~~~~~~~~~~~~~~~
intel_context_inflight_count
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_out':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:551:2: error: implicit declaration of function 'intel_context_inflight_dec'; did you mean 'intel_context_inflight'? [-Werror=implicit-function-declaration]
intel_context_inflight_dec(rq->hw_context);
^~~~~~~~~~~~~~~~~~~~~~~~~~
intel_context_inflight
cc1: some warnings being treated as errors
vim +541 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
77f0d0e925e8a0 drivers/gpu/drm/i915/i915_guc_submission.c Chris Wilson 2017-05-17 534
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 535 static struct i915_request *schedule_in(struct i915_request *rq, int idx)
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 536 {
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 537 trace_i915_request_in(rq, idx);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 538
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 539 if (!rq->hw_context->inflight)
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 540 rq->hw_context->inflight = rq->engine;
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 @541 intel_context_inflight_inc(rq->hw_context);
c7302f204490f3 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Chris Wilson 2019-08-08 542 intel_gt_pm_get(rq->engine->gt);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 543
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 544 return i915_request_get(rq);
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 545 }
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 546
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 547 static void schedule_out(struct i915_request *rq)
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 548 {
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 549 trace_i915_request_out(rq);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 550
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 @551 intel_context_inflight_dec(rq->hw_context);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 552 if (!intel_context_inflight_count(rq->hw_context))
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 553 rq->hw_context->inflight = NULL;
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 554
c7302f204490f3 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Chris Wilson 2019-08-08 555 intel_gt_pm_put(rq->engine->gt);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 556 i915_request_put(rq);
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 557 }
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 558
:::::: The code at line 541 was first introduced by commit
:::::: 22b7a426bbe1ebe1520f92da4cd1617d1e1b5fc4 drm/i915/execlists: Preempt-to-busy
:::::: TO: Chris Wilson <chris at chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris at chris-wilson.co.uk>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 28082 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190812/b9acc163/attachment-0001.gz>
More information about the Intel-gfx
mailing list