[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E0

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Aug 14 07:27:26 UTC 2019


Quoting Dong Yang (2019-08-14 03:44:48)
> From: "Yang, Dong" <dong.yang at intel.com>
> 
> Broxton steppings starting from GT E0 have fixed the bug, remove
> WA since stepping GT E0.

In i915 patches, we keep a changelog of what was changed compared to the
previous iteration (see git log drivers/gpu/drm/i915 for example) and then
use "-v" option in git send-email/format-patch to indicate the patch
series iteration.

You also want to Cc: the folks who did review on the previous, for
easier tracking.

Regards, Joonas

> 
> Signed-off-by: Yang, Dong <dong.yang at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 5f3e5c13fbaa..95519bac8948 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
>  #define BXT_REVID_B0           0x3
>  #define BXT_REVID_B_LAST       0x8
>  #define BXT_REVID_C0           0x9
> +#define BXT_REVID_D0           0xC
> +#define BXT_REVID_E0           0xD
>  
>  #define IS_BXT_REVID(dev_priv, since, until) \
>         (IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
> @@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct drm_i915_private *dev_priv)
>  static inline bool
>  intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>  {
> -       return IS_BROXTON(dev_priv) && intel_vtd_active();
> +       return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
>  }
>  
>  /* i915_drv.c */
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list