[Intel-gfx] [PATCH] drm/i915/guc: Remove client->submissions

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 14 08:00:18 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-08-14 01:21:45)
> The engine->guc_id is GuC FW defined and it is not guaranteed to be
> below I915_NUM_ENGINES, so we shouldn't use it with the i915-defined
> client->submissions, as we might overflow.
> Instead of fixing it, just get rid of client->submissions, because the
> information we get from it is not interesting anymore now that we only
> have 1 client.

It was ever useful? Umpteen billion submissions here, umpteen billion
submissions there. Or the other extreme, 1. No more, no less :)
 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list