[Intel-gfx] [PATCH v2] drm/i915: Disregard drm_mode_config.fb_base

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 14 08:43:03 UTC 2019


Quoting Srivatsa, Anusha (2019-08-14 00:41:15)
> 
> 
> > -----Original Message-----
> > From: Chris Wilson <chris at chris-wilson.co.uk>
> > Sent: Tuesday, August 13, 2019 11:21 AM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>; Daniel Vetter
> > <daniel.vetter at ffwll.ch>; Maarten Lankhorst
> > <maarten.lankhorst at linux.intel.com>; Srivatsa, Anusha
> > <anusha.srivatsa at intel.com>
> > Subject: [PATCH v2] drm/i915: Disregard drm_mode_config.fb_base
> > 
> > The fb_base is only used for communicating the GTT BAR from one piece of the
> > display code (kms setup) to another (fbdev). What is required in the fbdev is just
> > the aperture address which should be derived from the bo we allocate for the
> > framebuffer directly.
> > 
> > The same appears true for drm/; it is not used by the core or the uAPI, it is
> > merely for conveniently passing a device address from bit of display
> > management code to another.
> > 
> > v2: Note that since we only expose enough of a system map to cover our single
> > framebuffer, the screen_base/size and the smem are one and the same.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> 
> Reviewed-by: Anusha Srivatsa <anusha.srivatsa at intel.com>

Plonked it in as I hope it stands it stead as a nice little
simplification.
-Chris


More information about the Intel-gfx mailing list