[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Restore seqlock around dma_resv updates

Patchwork patchwork at emeril.freedesktop.org
Wed Aug 14 19:06:32 UTC 2019


== Series Details ==

Series: dma-buf: Restore seqlock around dma_resv updates
URL   : https://patchwork.freedesktop.org/series/65196/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
cffdefd474fc dma-buf: Restore seqlock around dma_resv updates
-:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 67c97fb79a7f ("dma-buf: add reservation_object_fences helper")'
#7: 
67c97fb79a7f ("dma-buf: add reservation_object_fences helper")

-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit dd7a7d1ff2f1 ("drm/i915: use new reservation_object_fences helper")'
#8: 
dd7a7d1ff2f1 ("drm/i915: use new reservation_object_fences helper")

-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0e1d8083bddb ("dma-buf: further relax reservation_object_add_shared_fence")'
#9: 
0e1d8083bddb ("dma-buf: further relax reservation_object_add_shared_fence")

-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 5d344f58da76 ("dma-buf: nuke reservation_object seq number")'
#10: 
5d344f58da76 ("dma-buf: nuke reservation_object seq number")

-:31: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#31: FILE: drivers/dma-buf/dma-buf.c:202:
+	unsigned shared_count, seq;

-:62: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#62: FILE: drivers/dma-buf/dma-buf.c:1160:
+	unsigned seq;

-:97: WARNING:STATIC_CONST_CHAR_ARRAY: const array should probably be static const
#97: FILE: drivers/dma-buf/dma-resv.c:55:
+const char reservation_seqcount_string[] = "reservation_seqcount";

-:154: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#154: FILE: drivers/dma-buf/dma-resv.c:315:
+	unsigned i;

-:165: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#165: FILE: drivers/dma-buf/dma-resv.c:324:
+		unsigned shared_count = src_list->shared_count;

-:230: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#230: FILE: drivers/dma-buf/dma-resv.c:414:
+		shared_count = i = 0;

-:269: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#269: FILE: drivers/dma-buf/dma-resv.c:504:
+	unsigned seq, shared_count;

-:315: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#315: FILE: drivers/dma-buf/dma-resv.c:603:
+	unsigned seq, shared_count;

total: 4 errors, 7 warnings, 1 checks, 513 lines checked



More information about the Intel-gfx mailing list