[Intel-gfx] [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini
Matthew Auld
matthew.auld at intel.com
Fri Aug 16 10:53:56 UTC 2019
If we are leaking nodes don't hide it. Also stop trying to be
"defensive" and instead embrace Kasan et al.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_buddy.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_buddy.c b/drivers/gpu/drm/i915/i915_buddy.c
index b679ab6fd889..5995247fdf76 100644
--- a/drivers/gpu/drm/i915/i915_buddy.c
+++ b/drivers/gpu/drm/i915/i915_buddy.c
@@ -171,15 +171,10 @@ int i915_buddy_init(struct i915_buddy_mm *mm, u64 size, u64 chunk_size)
void i915_buddy_fini(struct i915_buddy_mm *mm)
{
- int err = 0;
int i;
for (i = 0; i < mm->n_roots; ++i) {
- if (!i915_buddy_block_is_free(mm->roots[i])) {
- err = -EBUSY;
- continue;
- }
-
+ GEM_WARN_ON(!i915_buddy_block_is_free(mm->roots[i]));
i915_block_free(mm->roots[i]);
}
--
2.20.1
More information about the Intel-gfx
mailing list