[Intel-gfx] [PATCH 3/3] drm/i915/uc: Never fail on HuC firmware errors

[Michal Wajdeczko]

On Sun, 18 Aug 2019 12:00:11 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2019-08-18 10:52:04)
>> There is no need to mark whole GPU as wedged just because
>> of the custom HuC fw failure as users can always verify
>> actual HuC firmware status using existing HUC_STATUS ioctl.
>
> If we try and fail, would it not be worth a dev_notice?

if GuC is ok and if HuC was enabled there will be something like this:

<6> i915 0000:00:02.0: GuC firmware i915/kbl_guc_33.0.0.bin version 33.0  
submission:disabled
<6> i915 0000:00:02.0: HuC firmware i915/kbl_huc_ver02_00_1810.bin version  
2.0 authenticated:no

otherwise we should get:

<5> i915 0000:00:02.0: GuC is uninitialized

>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>
> Either way,
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris