[Intel-gfx] [PATCH 02/10] drm/i915: Generalise the clflush dma-worker

Chris Wilson chris at chris-wilson.co.uk
Mon Aug 19 18:32:59 UTC 2019


Quoting Matthew Auld (2019-08-19 19:16:20)
> On Mon, 19 Aug 2019 at 17:45, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> >
> > Extract the dma-fence worker used by clflush for wider use, as we
> > anticipate using workers coupled to dma-fences more frequently.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> <snip>
> 
> > +
> > +static const char *get_timeline_name(struct dma_fence *fence)
> > +{
> > +       return "work";
> > +}
> 
> work->name, or not all that useful for debug?

Hmm. work->name feels like overkill. If we could "%pS" work->fn...

That turns out to kallsyms_lookup(), but it takes a namebuf.

With two function pointers, I was thinking we should move to a const
vfunc table, given the various issues with overwriting function points.
We can throw a name in there.
-Chris


More information about the Intel-gfx mailing list