[Intel-gfx] [PATCH v2 2/2] drm/i915: Introduce intel_reg_types.h

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 20 14:26:38 UTC 2019


Quoting Chris Wilson (2019-08-20 12:16:36)
> Quoting Daniele Ceraolo Spurio (2019-08-20 03:01:47)
> > With the introduction of display uncore, we want to categorize registers
> > between display and non-display. To help us getting it right, it will
> > be useful to move the display registers to a new file that can be used
> > without including i915_reg.h. To allow that, move all the basic register
> > type definitions and helpers to intel_reg_types.h and include that
> > instead of i915_reg.h from header files in the driver. We'll then
> > be able to replace i915_reg.h with the new display-only header in
> > display files and make sure the registers are correctly
> > compartmentalized.
> > 
> > While at it, rename i915_reg.h to intel_reg.h to better indicate that it
> > contains HW defs.
> > 
> > v2: use intel_* prefix for register files (Michal)
> > 
> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> 
> After some mulling, intel_[subsys]_reg.h & intel_reg_types.h workforme,
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Applied the vlv_s0ix cleanup, but left this as this deserves a few more
acks.
-Chris


More information about the Intel-gfx mailing list