[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Hold irq-off for the entire fake lock period (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Aug 23 16:48:40 UTC 2019


== Series Details ==

Series: series starting with [01/15] drm/i915: Hold irq-off for the entire fake lock period (rev3)
URL   : https://patchwork.freedesktop.org/series/65705/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
173c1bc89e03 drm/i915: Hold irq-off for the entire fake lock period
d896cc87daca drm/i915/gtt: Preallocate Braswell top-level page directory
-:45: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#45: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:1017:
+		*cs++ = MI_LOAD_REGISTER_IMM(2 * GEN8_3LVL_PDPES) | MI_LRI_FORCE_POSTED;;

-:57: WARNING:MEMORY_BARRIER: memory barrier without comment
#57: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:165:
+	wmb();

-:65: WARNING:MEMORY_BARRIER: memory barrier without comment
#65: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1424:
+	wmb();

total: 0 errors, 3 warnings, 0 checks, 47 lines checked
bb4855e5c4eb drm/i915/selftests: Teach igt_gpu_fill_dw() to take intel_context
0f977fd1da12 dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal")'
#14: 
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked

total: 1 errors, 0 warnings, 0 checks, 24 lines checked
a0f807f2b948 drm/i915: Make shrink/unshrink be atomic
bb43a3b5113b drm/i915: Mark up obj->pin_global as being atomic
3ec9eadcdacb drm/i915: Only track bound elements of the GTT
332370ea8b41 drm/i915: Make i915_vma.flags atomic_t for mutex reduction
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 337 lines checked
3631ac00b48a drm/i915: Mark up address spaces that may need to allocate
edba6cc97869 drm/i915: Pull i915_vma_pin under the vm->mutex
5ac14777c21e drm/i915: Push the i915_active.retire into a worker
79f3b830651c drm/i915: Coordinate i915_active with its own mutex
-:1299: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1299: FILE: drivers/gpu/drm/i915/i915_active_types.h:49:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1448 lines checked
e2518334238f drm/i915: Move idle barrier cleanup into engine-pm
b23c41cf1147 drm/i915: Drop struct_mutex from around i915_retire_requests()
061e95161125 drm/i915: Serialise the fill BLT with the vma pinning



More information about the Intel-gfx mailing list