[Intel-gfx] [PATCH 5/5] drm/i915: cpu-map based dumb buffers

[Abdiel Janulgue]

On 26/08/2019 15.48, Chris Wilson wrote:
> Quoting Abdiel Janulgue (2019-08-26 13:21:02)
>> +int
>> +i915_gem_mmap_dumb(struct drm_file *file,
>> +                 struct drm_device *dev,
>> +                 u32 handle,
>> +                 u64 *offset)
>> +{
>> +       struct drm_i915_private *i915 = dev->dev_private;
>> +       enum i915_mmap_type mmap_type = HAS_MAPPABLE_APERTURE(i915) ?
>> +               I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_OFFSET_WC;
> 
> Is there any reason for using GTT if we support WC? The buffer is meant
> to be linear.
> -Chris
>

Actually there seems no reason at all. Yeah dumb BO mmaps should
probably be done via mmap_offset CPU WC mmaps.

-Abdiel