[Intel-gfx] [PATCH 0/3] Add/modify checks within intel_uc_fini_hw

Fernando Pacheco fernando.pacheco at intel.com
Wed Aug 28 00:45:55 UTC 2019


The third patch in the series attempts to downgrade the check for
is_guc_running to is_fw_available within intel_uc_fini_hw. We cannot
rely on is_guc_running because we will completely skip our attempt to
fini uC hw during unload. However, this exposes a new set of problems due
to the driver being able to continue after GuC initialization failures:
we can now try to disable submission or communication that was never enabled
in the first place.

The first two patches attempt to resolve those issues by adding
(hopefully stronger) checks around submission_disable and
communication_disable.

Thanks,
Fernando

Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Fernando Pacheco (3):
  drm/i915/uc: Extract common code from GuC stop/disable comm
  drm/i915/uc: Disable GuC submission only if currently enabled
  drm/i915/uc: Fini hw even if GuC is not running

 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 23 +++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 34 +++++++++++--------
 3 files changed, 44 insertions(+), 14 deletions(-)

-- 
2.23.0



More information about the Intel-gfx mailing list