[Intel-gfx] [PATCH v11 09/10] drm/i915/perf: execute OA configuration from command stream

[Chris Wilson]

Quoting Lionel Landwerlin (2019-08-28 15:33:26)
> +       rq = i915_request_create(i915->engine[RCS0]->kernel_context);
> +       if (IS_ERR(rq))
> +               return PTR_ERR(rq);
> +
> +       err = i915_active_request_set(&i915->engine[RCS0]->last_oa_config,
> +                                     rq);

I am still not sold on putting the global oa_config timeline on the
engine, and still dislike the suggestion of using struct_mutex to
management it.

You will notice that i915_active_request_set() checks that you have the
mutex held that your initialised with (in this case that is a *NULL).
-Chris