[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/36] drm/i915/execlists: Try rearranging breadcrumb flush

Patchwork patchwork at emeril.freedesktop.org
Thu Aug 29 09:34:35 UTC 2019


== Series Details ==

Series: series starting with [01/36] drm/i915/execlists: Try rearranging breadcrumb flush
URL   : https://patchwork.freedesktop.org/series/65979/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e26974d219f7 drm/i915/execlists: Try rearranging breadcrumb flush
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
References: e8f6b4952ec5 ("drm/i915/execlists: Flush the post-sync breadcrumb write harder")

-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e8f6b4952ec5 ("drm/i915/execlists: Flush the post-sync breadcrumb write harder")'
#12: 
References: e8f6b4952ec5 ("drm/i915/execlists: Flush the post-sync breadcrumb write harder")

total: 1 errors, 1 warnings, 0 checks, 29 lines checked
0fb6615cf3fc drm/i915/gtt: Downgrade Baytrail back to aliasing-ppgtt
33b0730f3327 drm/i915/gtt: Downgrade Cherryview back to aliasing-ppgtt
39dfca6990e2 drm/i915: Remove ppgtt->dirty_engines
9f66d9fd9414 drm/i915: Use RCU for unlocked vm_idr lookup
37279f73ea34 drm/i915: Replace obj->pin_global with obj->frontbuffer
-:242: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#242: FILE: drivers/gpu/drm/i915/i915_debugfs.c:219:
+		seq_printf(m, " (fb)");

total: 0 errors, 1 warnings, 0 checks, 171 lines checked
9fd7e84ab1ca dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal")'
#14: 
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked

total: 1 errors, 0 warnings, 0 checks, 24 lines checked
d3d63c1b2c8f drm/mm: Pack allocated/scanned boolean into a bitfield
4417343bd39f drm/i915: Make shrink/unshrink be atomic
034716c1de88 drm/i915: Only track bound elements of the GTT
74fbb381ed9c drm/i915: Make i915_vma.flags atomic_t for mutex reduction
cb8ed93e62e6 drm/i915: Mark up address spaces that may need to allocate
fb0a9a6ba5d4 drm/i915: Pull i915_vma_pin under the vm->mutex
-:2433: WARNING:MEMORY_BARRIER: memory barrier without comment
#2433: FILE: drivers/gpu/drm/i915/i915_vma.c:804:
+		smp_mb__before_atomic();

total: 0 errors, 1 warnings, 0 checks, 3073 lines checked
82c61476b3fd drm/i915: Push the i915_active.retire into a worker
69819ddd016c drm/i915: Coordinate i915_active with its own mutex
-:1427: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1427: FILE: drivers/gpu/drm/i915/i915_active_types.h:49:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1575 lines checked
2ca0d1818be6 drm/i915: Move idle barrier cleanup into engine-pm
66b692177a8b drm/i915: Drop struct_mutex from around i915_retire_requests()
25fbe51e5bb4 drm/i915: Remove the GEM idle worker
1c07adf26864 drm/i915: Merge wait_for_timelines with retire_request
eae2742f6fe2 drm/i915: Move request runtime management onto gt
-:228: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#228: 
new file mode 100644

-:233: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#233: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:1:
+/*

-:234: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#234: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:2:
+ * SPDX-License-Identifier: MIT

-:357: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#357: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:1:
+/*

-:358: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#358: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 696 lines checked
bdbdd12232a3 drm/i915: Move global activity tracking from GEM to GT
4edc4008cdf9 drm/i915: Serialise the fill BLT with the vma pinning
7a2563bf16cc drm/i915/execlists: Always request completion before marking an error
6f5fb73c04da drm/i915: Only enqueue already completed requests
bd12fdc3172f drm/i915/execlists: Force preemption
0611888eaf64 drm/i915: Mark up "sentinel" requests
359667d6c54a drm/i915/execlists: Cancel banned contexts on schedule-out
b3d54f7494b4 drm/i915: Cancel non-persistent contexts on close
-:284: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#284: 
new file mode 100644

-:289: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#289: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:1:
+/*

-:290: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#290: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:2:
+ * SPDX-License-Identifier: MIT

-:351: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#351: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:1:
+/*

-:352: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#352: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 322 lines checked
0848762f1e34 drm/i915: Replace hangcheck by heartbeats
-:212: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#212: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:63:
+					  "%s heartbeat not ticking\n",

-:229: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#229: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:80:
+					      "stopped heartbeat on %s",

-:455: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#455: 
deleted file mode 100644

total: 0 errors, 3 warnings, 0 checks, 602 lines checked
0fde4766d712 drm/i915/pmu: Use GT parked for estimating RC6 while asleep
4a41121f9b46 drm/i915: Remove logical HW ID
1fe49a4dba49 drm/i915: Move context management under GEM
-:1333: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1333: FILE: drivers/gpu/drm/i915/i915_drv.h:1694:
+			struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1509 lines checked
99554ea7318c drm/i915/overlay: Drop struct_mutex guard
a3d861c6c60d drm/i915: Drop struct_mutex from suspend state save/restore
f02d80bfe217 drm/i915/selftest: Drop vestigal struct_mutex guards
0e6a75b97ba3 drm/i915: Drop struct_mutex from around GEM initialisation



More information about the Intel-gfx mailing list