[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display uncore helpers

Patchwork patchwork at emeril.freedesktop.org
Mon Dec 2 17:29:25 UTC 2019


== Series Details ==

Series: drm/i915: add display uncore helpers
URL   : https://patchwork.freedesktop.org/series/70298/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
aa62137b3200 drm/i915/gvt: use intel uncore functions for forcewake register access
-:66: ERROR:CODE_INDENT: code indent should use tabs where possible
#66: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:499:
+^I^I^I^I^I^I^I^I           mmio->reg);$

-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:499:
+			vgpu_vreg_t(pre, mmio->reg) = intel_uncore_read_fw(&dev_priv->uncore,
+								           mmio->reg);

-:73: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#73: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:505:
+			old_v = mmio->value = intel_uncore_read_fw(&dev_priv->uncore,

total: 1 errors, 0 warnings, 2 checks, 77 lines checked
726cf8776bad drm/i915/debugfs: use intel uncore functions for forcewake register access
33c73c270802 drm/i915/dmc: use intel uncore functions for forcewake register access
e6d3be1b2221 drm/i915: add display engine uncore helpers
-:34: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 99 lines checked
bc24ff104c6a drm/i915/display: use intel de functions for forcewake register access
9af777404acc drm/i915/irq: use intel de functions for forcewake register access
-:79: WARNING:LONG_LINE: line over 100 characters
#79: FILE: drivers/gpu/drm/i915/i915_irq.c:823:
+		position = (intel_de_read_fw(dev_priv, PIPEFRAMEPIXEL(pipe)) & PIPE_PIXEL_MASK) >> PIPE_PIXEL_SHIFT;

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
180f3b87f219 drm/i915/gmbus: use intel de functions for forcewake register access
-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: drivers/gpu/drm/i915/display/intel_gmbus.c:414:
+			  gmbus1_index | GMBUS_CYCLE_WAIT | (size << GMBUS_BYTE_COUNT_SHIFT) | (addr << GMBUS_SLAVE_ADDR_SHIFT) | GMBUS_SLAVE_READ | GMBUS_SW_RDY);

-:163: WARNING:LONG_LINE: line over 100 characters
#163: FILE: drivers/gpu/drm/i915/display/intel_gmbus.c:493:
+			  gmbus1_index | GMBUS_CYCLE_WAIT | (chunk_size << GMBUS_BYTE_COUNT_SHIFT) | (addr << GMBUS_SLAVE_ADDR_SHIFT) | GMBUS_SLAVE_WRITE | GMBUS_SW_RDY);

total: 0 errors, 2 warnings, 0 checks, 205 lines checked
b4fbec26c2bf drm/i915/sprite: use intel de functions for forcewake register access
-:152: WARNING:LONG_LINE: line over 100 characters
#152: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:666:
+				  (plane_state->color_plane[1].y << 16) | plane_state->color_plane[1].x);

total: 0 errors, 1 warnings, 0 checks, 509 lines checked
9db3c03d508b drm/i915/pm: use intel de functions for forcewake register access
0afb72393e86 drm/i915: remove I915_READ_FW() and I915_WRITE_FW() macros



More information about the Intel-gfx mailing list